fix(reactivity): make items in a readonly&reactive map trigger effects #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picknight
reviewed
Aug 6, 2020
| return get( | ||
| this, | ||
| key, | ||
| isReactive(this) ? value => toReadonly(toReactive(value)) : toReadonly |
There was a problem hiding this comment.
You can pass the above test case without changing here :)
There was a problem hiding this comment.
Oh It's the problem with my test cases. I will rewrite it.
There was a problem hiding this comment.
hi I've rewritten the test case: it should be an object in the map.
|
solved by ed43810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the problem:
assume that a map has two proxies, one of which is readonly and the other is reactive, if we modify items in the map by the reactive one proxy, watcher callbacks on the readonly one won't work, as discussed in #1772, which can be a very common usage scenario for map.
however changed the strategy on handling a reactive and readonly map at the same time.